🎨 DSFR - Admin & Mon DomiFa - Branche principale ⭐ #3855

pYassine · 2025-08-13T19:05:32Z

No description provided.

revu-bot

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR changes 49 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

Total files changed: 49
Reviewable files: 49
Diff size: 2190 lines
Documentation files: 0
Largest file change: 408 lines
Addition/Deletion ratio: 0.93

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

socket-security · 2025-09-17T15:22:02Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

* feat(mon-domifa): init dsfr * fix(yarn): fix yarn.lock * fix(yarn): fix yarn.lock * feat(mon-domifa): init dsfr * feat(front): footer dsfr portails admin & usagers * fix(admin-usagers): mise en conformité à la NOUVELLE maquette --------- Co-authored-by: Yassine R. <riffi.yassine@gmail.com>

* feat(usagers): integration header mon domifa * feat(usagers): fix reviews * fix(usagers): fix reviews

sonarqubecloud · 2025-09-23T21:32:13Z

Quality Gate failed

Failed conditions
19.4% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

tokenbureau · 2025-09-23T21:40:53Z

🎉 Deployment for commit 0aa3986 :

Ingresses

Docker images

📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-0aa3986ca98c52a6ba7f6705915c58930c12242d
📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-0aa3986ca98c52a6ba7f6705915c58930c12242d
📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-0aa3986ca98c52a6ba7f6705915c58930c12242d
📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-0aa3986ca98c52a6ba7f6705915c58930c12242d

Debug

pYassine · 2025-09-24T07:57:08Z

.../portail-admins/src/app/modules/shared/components/custom-toastr/custom-toastr.component.html

+  [severity]="toast.class === 'success' ? 'success' : 'error'"
+  [ariaRoleValue]="'alert'"
+  [hasAriaRole]="false"
+  [closeable]="toast.dissmissable"


Ca ne fonctionne pas sur la démo. Je suis d'avis de le retirer pour l'instant, on va perdre du temps à essayer de corriger le souci

pYassine · 2025-09-24T07:57:33Z

packages/portail-admins/src/app/app.component.html

+      link: '/plan-site',
+    },
+    {
+      label: 'Nos partenaires',


@hbalty a retirer

pYassine · 2025-09-24T07:57:39Z

packages/portail-admins/src/app/app.component.html

+      link: '/cgu',
+    },
+    {
+      label: 'Polotiques de confidentialité',


@hbalty typo

pYassine · 2025-09-24T07:58:30Z

packages/portail-usagers/src/app/app.component.html

+            données, consultez notre</span
+          >
+          <a
+            rel="noopener external"


le "rel" est à retirer, on est sur un lien interne @hbalty

pYassine · 2025-09-24T07:58:41Z

packages/portail-usagers/src/app/app.component.html

+      link: '/plan-site',
+    },
+    {
+      label: 'Nos partenaires',


A retirer dans l'admin & mon domifa

revu-bot bot requested a review from revu-bot August 13, 2025 19:05

pYassine force-pushed the feat-dsfr-mon-domifa branch from 6de7b54 to 7402835 Compare August 18, 2025 15:20

pYassine temporarily deployed to build-review-auto August 18, 2025 15:20 — with GitHub Actions Inactive

pYassine had a problem deploying to build-review-auto August 18, 2025 15:20 — with GitHub Actions Failure

pYassine temporarily deployed to build-review-auto August 18, 2025 15:20 — with GitHub Actions Inactive

pYassine marked this pull request as ready for review August 18, 2025 17:01

revu-bot reviewed Aug 18, 2025

View reviewed changes

pYassine changed the title ~~feat(mon-domifa): init dsfr Admin & Mon DomiFa~~ 1️⃣ feat(mon-domifa): init dsfr Admin & Mon DomiFa Sep 9, 2025

hbalty force-pushed the feat-dsfr-mon-domifa branch from 7402835 to 1bd54cf Compare September 17, 2025 15:17

hbalty temporarily deployed to build-review-auto September 17, 2025 15:17 — with GitHub Actions Inactive

hbalty had a problem deploying to build-review-auto September 17, 2025 15:17 — with GitHub Actions Failure

hbalty temporarily deployed to build-review-auto September 17, 2025 15:17 — with GitHub Actions Inactive

hbalty force-pushed the feat-dsfr-mon-domifa branch from 1bd54cf to bbb883c Compare September 17, 2025 16:15

hbalty had a problem deploying to build-review-auto September 17, 2025 16:15 — with GitHub Actions Failure

hbalty temporarily deployed to build-review-auto September 17, 2025 16:15 — with GitHub Actions Inactive

hbalty force-pushed the feat-dsfr-mon-domifa branch from bbb883c to b45904d Compare September 18, 2025 14:43

hbalty temporarily deployed to build-review-auto September 18, 2025 14:43 — with GitHub Actions Inactive

hbalty had a problem deploying to build-review-auto September 18, 2025 14:43 — with GitHub Actions Failure

hbalty temporarily deployed to build-review-auto September 18, 2025 14:43 — with GitHub Actions Inactive

hbalty force-pushed the feat-dsfr-mon-domifa branch from b45904d to d476827 Compare September 19, 2025 09:42

hbalty temporarily deployed to build-review-auto September 19, 2025 09:42 — with GitHub Actions Inactive

hbalty temporarily deployed to review-auto September 23, 2025 09:34 — with GitHub Actions Inactive

Feat dsfr pages statiques mon domifa - admin (#3910)

199eb95

hbalty temporarily deployed to build-review-auto September 23, 2025 09:44 — with GitHub Actions Inactive

hbalty temporarily deployed to review-auto September 23, 2025 09:45 — with GitHub Actions Inactive

hbalty temporarily deployed to build-review-auto September 23, 2025 10:19 — with GitHub Actions Inactive

hbalty temporarily deployed to review-auto September 23, 2025 10:26 — with GitHub Actions Inactive

fix(portails-admins): quick fix lien nos partenaire

c6cd651

hbalty temporarily deployed to build-review-auto September 23, 2025 11:50 — with GitHub Actions Inactive

hbalty temporarily deployed to review-auto September 23, 2025 11:51 — with GitHub Actions Inactive

feat(usagers): integration header mon domifa (#3923)

0aa3986

* feat(usagers): integration header mon domifa * feat(usagers): fix reviews * fix(usagers): fix reviews

hbalty temporarily deployed to build-review-auto September 23, 2025 21:31 — with GitHub Actions Inactive

hbalty temporarily deployed to review-auto September 23, 2025 21:32 — with GitHub Actions Inactive

pYassine commented Sep 24, 2025

View reviewed changes

pYassine added the 🛡️ Retours revue label Sep 24, 2025

pYassine changed the title ~~1️⃣ feat(mon-domifa): init dsfr Admin & Mon DomiFa~~ 🎨 DSFR - Admin & Mon DomiFa - Branche principale ⭐ Sep 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🎨 DSFR - Admin & Mon DomiFa - Branche principale ⭐ #3855

🎨 DSFR - Admin & Mon DomiFa - Branche principale ⭐ #3855

pYassine commented Aug 13, 2025

Uh oh!

revu-bot left a comment

Uh oh!

socket-security bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Sep 23, 2025

Uh oh!

tokenbureau bot commented Sep 23, 2025

Uh oh!

pYassine Sep 24, 2025

Uh oh!

pYassine Sep 24, 2025

Uh oh!

pYassine Sep 24, 2025

Uh oh!

pYassine Sep 24, 2025

Uh oh!

pYassine Sep 24, 2025

Uh oh!

Uh oh!

🎨 DSFR - Admin & Mon DomiFa - Branche principale ⭐ #3855

Are you sure you want to change the base?

🎨 DSFR - Admin & Mon DomiFa - Branche principale ⭐ #3855

Conversation

pYassine commented Aug 13, 2025

Uh oh!

revu-bot left a comment

Choose a reason for hiding this comment

Issues Found

PR Metrics

Uh oh!

socket-security bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 23, 2025

Quality Gate failed

Uh oh!

tokenbureau bot commented Sep 23, 2025

Uh oh!

pYassine Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

pYassine Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

pYassine Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

pYassine Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

pYassine Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

socket-security bot commented Sep 17, 2025 •

edited

Loading